Skip to content

chore: remove pedersen getHashTree#3069

Merged
kevaundray merged 7 commits intokw/pedersen-cleanup-remove-unused-cbindsfrom
kw/remove-get-hash-tree
Oct 26, 2023
Merged

chore: remove pedersen getHashTree#3069
kevaundray merged 7 commits intokw/pedersen-cleanup-remove-unused-cbindsfrom
kw/remove-get-hash-tree

Conversation

@kevaundray
Copy link
Contributor

@kevaundray kevaundray commented Oct 26, 2023

Related to #3029

We can merge this into kw/pedersen-cleanup-remove-unused-cbinds as part of the cleanup

Checklist:

Remove the checklist to signal you've completed it. Enable auto-merge if the PR is ready to merge.

  • If the pull request requires a cryptography review (e.g. cryptographic algorithm implementations) I have added the 'crypto' tag.
  • I have reviewed my diff in github, line by line and removed unexpected formatting changes, testing logs, or commented-out code.
  • Every change is related to the PR description.
  • I have linked this pull request to relevant issues (if any exist).

@kevaundray kevaundray marked this pull request as ready for review October 26, 2023 15:24
@AztecBot
Copy link
Collaborator

AztecBot commented Oct 26, 2023

Benchmark results

Metrics with a significant change:

  • note_history_successful_decrypting_time_in_ms (5): 2,412 (+24%)
  • note_history_successful_decrypting_time_in_ms (10): 4,739 (+25%)
Detailed results

All benchmarks are run on txs on the Benchmarking contract on the repository. Each tx consists of a batch call to create_note and increment_balance, which guarantees that each tx has a private call, a nested private call, a public call, and a nested public call, as well as an emitted private note, an unencrypted log, and public storage read and write.

This benchmark source data is available in JSON format on S3 here.

Values are compared against data from master at commit 9b6be227 and shown if the difference exceeds 1%.

L2 block published to L1

Each column represents the number of txs on an L2 block published to L1.

Metric 8 txs 32 txs 128 txs
l1_rollup_calldata_size_in_bytes 45,444 179,588 716,132
l1_rollup_calldata_gas 222,996 868,172 3,449,372
l1_rollup_execution_gas 842,083 3,595,280 22,204,741
l2_block_processing_time_in_ms 2,730 (-2%) 10,269 (-3%) 40,234 (-2%)
note_successful_decrypting_time_in_ms 334 (-3%) 1,026 (-3%) 3,802 (-3%)
note_trial_decrypting_time_in_ms 36.0 (-27%) 110 144 (-3%)
l2_block_building_time_in_ms 17,362 (-4%) 69,347 (-3%) 276,097 (-3%)
l2_block_rollup_simulation_time_in_ms 15,801 (-4%) 63,121 (-3%) 250,983 (-3%)
l2_block_public_tx_process_time_in_ms 1,512 (-3%) 6,077 (-2%) 24,556 (-2%)

L2 chain processing

Each column represents the number of blocks on the L2 chain where each block has 16 txs.

Metric 5 blocks 10 blocks
node_history_sync_time_in_ms 28,830 (+15%) 56,642 (+15%)
note_history_successful_decrypting_time_in_ms ⚠️ 2,412 (+24%) ⚠️ 4,739 (+25%)
note_history_trial_decrypting_time_in_ms 126 (+3%) 156 (+6%)
node_database_size_in_bytes 1,629,630 1,096,413
pxe_database_size_in_bytes 27,188 54,187

Circuits stats

Stats on running time and I/O sizes collected for every circuit run across all benchmarks.

Circuit circuit_simulation_time_in_ms circuit_input_size_in_bytes circuit_output_size_in_bytes
private-kernel-init 96.3 (+7%) 61,697 18,841
private-kernel-ordering 59.1 (+6%) 24,233 8,089
base-rollup 2,423 (+6%) 656,309 811
root-rollup 109 (+14%) 4,072 1,097
private-kernel-inner 69.8 (+7%) 81,504 18,841
public-kernel-private-input 54.7 (+7%) 41,455 18,841
public-kernel-non-first-iteration 34.4 (+8%) 41,497 18,841
merge-rollup 1.12 (+3%) 2,592 873

Miscellaneous

Transaction sizes based on how many contracts are deployed in the tx.

Metric 0 deployed contracts 1 deployed contracts
tx_size_in_bytes 8,723 27,240

@kevaundray kevaundray merged commit 5e78f63 into kw/pedersen-cleanup-remove-unused-cbinds Oct 26, 2023
@kevaundray kevaundray deleted the kw/remove-get-hash-tree branch October 26, 2023 16:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

No open projects
A3
Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@kevaundray @AztecBot